Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging of the new escaper classes #74

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

ehoogerbeets
Copy link
Contributor

Found these problems while attempting to use the new escapers from the regex plugin:

  • escapers weren't processed properly with babel so there were no transpiled js files for them
  • they weren't included as part of the package
  • escaperFactory wasn't exported from the index.js so you couldn't use it

Fortunately, the escapers changes in ilib-tools-common are not published yet, so we can just merge this and it will go out with the next publish.

- weren't processed properly with babel
- weren't included as part of the package
- escaperFactory wasn't exported from the index.js
@ehoogerbeets ehoogerbeets self-assigned this Mar 6, 2025
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 4e06d2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Jest Code Coverage

Code Coverage for changed files • (0%) 
File% Stmts% Branch% Funcs% LinesUncovered Line #s
report-only-changed-files is enabled. No files were changed in this commit :)
Title Lines Statements Branches Functions
ilib-lint-python Coverage: 73%
73.43% (141/192) 60.46% (52/86) 62.06% (18/29)
ilib-lint-python-gnu Coverage: 76%
75.15% (118/157) 71.18% (42/59) 60.97% (25/41)
ilib-lint-react Coverage: 96%
95.88% (303/316) 84.91% (152/179) 91.04% (61/67)
ilib-lint Coverage: 84%
83.99% (1485/1768) 75.38% (827/1097) 85.05% (296/348)
loctool Coverage: 81%
81.53% (6640/8144) 74.26% (3374/4543) 72.78% (757/1040)
Title Tests Skipped Failures Errors Time
ilib-lint-python 52 0 💤 0 ❌ 0 🔥 11.836s ⏱️
ilib-lint-python-gnu 35 0 💤 0 ❌ 0 🔥 3.07s ⏱️
ilib-lint-react 111 12 💤 0 ❌ 0 🔥 13.553s ⏱️
ilib-lint 657 0 💤 0 ❌ 0 🔥 10.481s ⏱️
loctool 2296 81 💤 0 ❌ 0 🔥 1m 9s ⏱️

@ehoogerbeets ehoogerbeets merged commit 6f0fcdd into main Mar 6, 2025
1 check passed
@ehoogerbeets ehoogerbeets deleted the fixToolsPackaging branch March 6, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants