Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ilib-loctool-json: Fix missing comment in XLIFF translation unit #67

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

ilib-loctool-json: Fix missing comment in XLIFF translation unit #67

wants to merge 7 commits into from
+1,328 −1,086

Conversation

nmkedziora
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: debe810

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2025 •
edited
Loading

Jest Code Coverage

Code Coverage for changed files • (0%) 
File% Stmts% Branch% Funcs% LinesUncovered Line #s
report-only-changed-files is enabled. No files were changed in this commit :)
Title Lines Statements Branches Functions
loctool Coverage: 81%
 81.53% (6640/8144) 74.26% (3374/4543) 72.78% (757/1040)
Title Tests Skipped Failures Errors Time
loctool 2296 81 💤 0 ❌ 0 🔥 58.245s ⏱️

@nmkedziora nmkedziora force-pushed the ilib-loctool-json-comments-support branch 2 times, most recently from 2f566e9 to 76861e8 Compare February 17, 2025 16:14
@nmkedziora nmkedziora changed the title ilib-loctool-json: WIP ilib-loctool-json: Fix missing comment in XLIFF translation unit Feb 17, 2025
nmkedziora
nmkedziora commented Feb 17, 2025
View reviewed changes
packages/ilib-loctool-json/JsonFile.js Outdated
Copy link
Contributor Author

@nmkedziora nmkedziora Feb 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bug to be fixed in current implementation is trimmed resname in sample-json-new-de-DE.xliff (two first letters are removed from the original resname when comapred to sample-json-new.xliff).

For details check the screenshot below.

Screenshot 2025-02-17 at 15 35 54

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tests are not added yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehoogerbeets Let me know what you think about this one.

@nmkedziora nmkedziora force-pushed the ilib-loctool-json-comments-support branch from 76861e8 to 57fca72 Compare March 6, 2025 14:47
@nmkedziora nmkedziora force-pushed the ilib-loctool-json-comments-support branch from a6a6673 to debe810 Compare March 7, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehoogerbeets ehoogerbeets ehoogerbeets left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmkedziora @ehoogerbeets