ilib-loctool-regex: Add new regex-based plugin #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ehoogerbeets
commented
Jan 6, 2025
ehoogerbeets
commented
- intended for file formats that are simple enough that they can be parsed with regular expressions
- settings in the project config file allow you to specify the regular expressions and how to handle the parts that they match
- outputs regular Resource instances
- cannot write any file format, so must be used with a resource file type
🦋 Changeset detectedLatest commit: 1c71485 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gouniLee
reviewed
Jan 13, 2025
gouniLee
reviewed
Jan 14, 2025
gouniLee
approved these changes
Jan 15, 2025
wadimw
reviewed
Jan 15, 2025
- all unit tests for the file type class pass. The file class needs a lot more work
- unit tests have been updated to test the right things but do not pass yet
- added testregex test utility to help in testing your regular expressions - more unit tests are passing, but not all of them yet
- also, make sure we can recover from a match that contains no source string
- now we keep track of the parts of the file that haven't been matched yet by previous regular expressions, and the subsequent regular expressions only match in those parts. In this way, there is a natural hierarchy to the expressions where the order of the expressions in the config file determines their priority. - added tips to the README to help people build their regular expressions - fixed a bug where Unicode escape sequences were not unescaped properly
ehoogerbeets
force-pushed
the
addRegexPlugin
branch
from
5a03694 to
fea9fd8
Compare
- also convert dependencies for ilib-locale and ilib-istring to intra-workspace dependencies
- switched to use the more standard `resourceFileTypes` setting that already exists in the loctool. This allows the loctool to manage the file types and cause them to write out their contents at the end of the loctool run. - previous method did not work. Loctool did not tell each resource file type to write itself out because it didn't know about the existence of the resource file types!
nmkedziora
reviewed
Jan 23, 2025
nmkedziora
approved these changes
Jan 29, 2025
wadimw
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.