Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the jest version of many packages to 29.7.0 so that they won't have a problem with ilib-po #36

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ehoogerbeets
Copy link
Contributor

There are conflicts between importing and requiring the new ilib-po via the loctool if jest is on version 26.X. Rather than adding this fix to the po intermediate file PR for the loctool, I'm doing this PR separately to make it cleaner.

@ehoogerbeets ehoogerbeets changed the title Fixed the jest version of many packages to 29.7.0 so that things won't have a problem with ilib-po Fixed the jest version of many packages to 29.7.0 so that they won't have a problem with ilib-po Dec 5, 2024
Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 7794254

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wadimw
Copy link
Contributor

wadimw commented Dec 13, 2024

Rebased on latest main

@wadimw
Copy link
Contributor

wadimw commented Dec 13, 2024

Errors in #31 which this PR was supposed to address were resolved in #42 and #43, but we were supposed to upgrade jest anyway so it still makes sense to merge this

@wadimw wadimw merged commit ed6cd16 into main Dec 13, 2024
1 check passed
@wadimw wadimw deleted the fixJestVersions branch December 13, 2024 15:27
wadimw pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants