Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow parameters with dots to be changed on command line #33

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

andresailer
Copy link
Contributor

@andresailer andresailer commented Feb 21, 2019

allows for changing LCFIPlus like parameters on command line

This would solve this problem lcfiplus/LCFIPlus#3 without invalidating all the existing XML files. As there are additional checks that parameter names are in the XML file

BEGINRELEASENOTES

ENDRELEASENOTES

allows for changing LCFIPlus like parameters on the commandline
JetVertexAndRefiner.JetClustering
@andresailer andresailer requested a review from gaede February 21, 2019 11:47
@andresailer
Copy link
Contributor Author

@gaede could you please have a look at these changes? Thanks

Copy link
Contributor

@gaede gaede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thanks.

@gaede gaede merged commit a3a59d2 into iLCSoft:master Mar 5, 2019
@andresailer andresailer deleted the lcfiParameterCLI branch March 5, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants