Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include GNUInstallDirs to set CMAKE_INSTALL_LIBDIR for MacOS builds #14

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Include GNUInstallDirs to set CMAKE_INSTALL_LIBDIR for MacOS builds #14

merged 1 commit into from
Jan 13, 2025

Conversation

jmcarcell
Copy link
Contributor

Include GNUInstallDirs in CMakeLists.txt

BEGINRELEASENOTES

  • Add GNUInstallDirs to set CMAKE_INSTALL_LIBDIR so that the default rpath is correct and can be used in downstream projects, like in k4MarlinWrapper

ENDRELEASENOTES

See iLCSoft/Marlin#62

@jmcarcell jmcarcell mentioned this pull request Jan 13, 2025
Merged
tmadlener
tmadlener approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update CI once more.

@tmadlener tmadlener enabled auto-merge (squash) January 13, 2025 08:59
@tmadlener tmadlener merged commit 3e98d19 into iLCSoft:master Jan 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener