Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.5.1_fixes #420

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

V1.5.1_fixes #420

wants to merge 23 commits into from

Conversation

nicHoch
Copy link
Collaborator

@nicHoch nicHoch commented Dec 10, 2024

fixes (already hotfixed in current daily and TM pipeline) after 1.5.0 release

  • new approach of finding unprocessed TM files
  • ANC files where not generated in "VXXU" mode
  • tmstatusflarelist l1 where missing dim/dmax ... definitions
  • new pipeline schema for TM processing (not event based any more / directory observing) now run every Xh processing all open TM files where no log exists for

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 3.52113% with 274 lines in your changes missing coverage. Please review.

Project coverage is 68.90%. Comparing base (5382d52) to head (a92c687).

Files with missing lines Patch % Lines
stixcore/processing/pipeline_cron.py 0.00% 252 Missing ⚠️
stixcore/processing/pipeline.py 9.09% 10 Missing ⚠️
stixcore/products/ANC/aspect.py 42.85% 4 Missing ⚠️
stixcore/processing/pipeline_daily.py 0.00% 3 Missing ⚠️
stixcore/products/level1/quicklookL1.py 66.66% 3 Missing ⚠️
stixcore/io/fits/processors.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   71.19%   68.90%   -2.29%     
==========================================
  Files          75       76       +1     
  Lines        7800     8069     +269     
==========================================
+ Hits         5553     5560       +7     
- Misses       2247     2509     +262     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicHoch nicHoch added this to the v1.5.1 milestone Jan 13, 2025
@nicHoch nicHoch assigned samaloney and nicHoch and unassigned samaloney Jan 13, 2025
@nicHoch nicHoch requested a review from samaloney January 13, 2025 15:01
@nicHoch nicHoch added the bug Something isn't working label Jan 13, 2025
@nicHoch nicHoch added the enhancement New feature or request label Jan 13, 2025
Copy link
Collaborator

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but looks good otherwise.

Comment on lines +13 to +14
logging_dir = Path(CONFIG.get('Pipeline', 'log_dir'))
logging_dir = Path("/data/stix/out/fits_v1.2.0/logging/")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only keep one?

Comment on lines +15 to +16
tm_dir = Path(CONFIG.get('Paths', 'tm_archive'))
tm_dir = Path("/data/stix/SOLSOC/from_edds/tm/incomming")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only keep one?

tm_dir = Path(CONFIG.get('Paths', 'tm_archive'))
tm_dir = Path("/data/stix/SOLSOC/from_edds/tm/incomming")
list_of_log_files = logging_dir.glob('*.xml.out')
latest_log_file = logging_dir / "TM_BatchRequest.PktTmRaw.SOL.0.2023.305.15.33.13.852.bBWz@2023.352.21.00.01.039.1.xml.out" # noqa
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardcoded?

TM_REGEX = re.compile(r'.*PktTmRaw.*.xml$')


class GFTSFileHandler(FileSystemEventHandler):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this class used here now, maybe a left over from a move/rename?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants