-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.5.1_fixes #420
base: master
Are you sure you want to change the base?
V1.5.1_fixes #420
Conversation
…over multiple days
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #420 +/- ##
==========================================
- Coverage 71.19% 68.90% -2.29%
==========================================
Files 75 76 +1
Lines 7800 8069 +269
==========================================
+ Hits 5553 5560 +7
- Misses 2247 2509 +262 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments but looks good otherwise.
logging_dir = Path(CONFIG.get('Pipeline', 'log_dir')) | ||
logging_dir = Path("/data/stix/out/fits_v1.2.0/logging/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only keep one?
tm_dir = Path(CONFIG.get('Paths', 'tm_archive')) | ||
tm_dir = Path("/data/stix/SOLSOC/from_edds/tm/incomming") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only keep one?
tm_dir = Path(CONFIG.get('Paths', 'tm_archive')) | ||
tm_dir = Path("/data/stix/SOLSOC/from_edds/tm/incomming") | ||
list_of_log_files = logging_dir.glob('*.xml.out') | ||
latest_log_file = logging_dir / "TM_BatchRequest.PktTmRaw.SOL.0.2023.305.15.33.13.852.bBWz@2023.352.21.00.01.039.1.xml.out" # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoded?
TM_REGEX = re.compile(r'.*PktTmRaw.*.xml$') | ||
|
||
|
||
class GFTSFileHandler(FileSystemEventHandler): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this class used here now, maybe a left over from a move/rename?
fixes (already hotfixed in current daily and TM pipeline) after 1.5.0 release