Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid reason/scaling lookup error handling #411

Merged
merged 16 commits into from
Nov 25, 2024

Conversation

nicHoch
Copy link
Collaborator

@nicHoch nicHoch commented Nov 11, 2024

No description provided.

@nicHoch nicHoch self-assigned this Nov 11, 2024
@nicHoch nicHoch requested a review from samaloney November 11, 2024 17:19
@nicHoch nicHoch added this to the v1.5.0 milestone Nov 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.81%. Comparing base (ae330f3) to head (0660c6a).

Files with missing lines Patch % Lines
stixcore/io/RidLutManager.py 62.50% 3 Missing ⚠️
stixcore/processing/pipeline.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   75.84%   75.81%   -0.03%     
==========================================
  Files          68       68              
  Lines        7257     7262       +5     
==========================================
+ Hits         5504     5506       +2     
- Misses       1753     1756       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@samaloney samaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just to confirm the E2E test fails are due to the python issue on the server?

@nicHoch nicHoch force-pushed the get_rid_error_handling branch from bbd5550 to 0660c6a Compare November 25, 2024 08:17
@nicHoch nicHoch merged commit 5262249 into i4Ds:master Nov 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants