Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small fixes for data release #375

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

samaloney
Copy link
Collaborator

@samaloney samaloney commented Nov 29, 2023

Fixes:

  1. Actually calculate the Carrington coordinate frame values and use in the headers, closes Value of Carrington longitude is not correct #355
  2. Fix casting issue with fits ext for energy table, closes Slight discrepancies in energy edges  #359
  3. Remove num_energy_groups, closes num_energy_groups changes rapidly with time  #367
  4. Remove energy extension from QL Calibration data, close Remove energy extension from calibration data #338

@samaloney samaloney changed the title Fix Carrington Longitude calculation and value in header Various small fixes data release Nov 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b94f0f8) 78.45% compared to head (54a76b2) 77.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   78.45%   77.79%   -0.66%     
==========================================
  Files          65       65              
  Lines        6775     6777       +2     
==========================================
- Hits         5315     5272      -43     
- Misses       1460     1505      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Properly enable end2end test mark (so '-m end2end' works)
* Disbale parrallel execution as causing error
@samaloney samaloney changed the title Various small fixes data release Various small fixes for data release Nov 30, 2023
@samaloney samaloney force-pushed the bugfix-carrington-lon branch 3 times, most recently from 92a98e0 to 3a95fbb Compare November 30, 2023 15:29
@samaloney samaloney force-pushed the bugfix-carrington-lon branch from 3a95fbb to 885ad47 Compare November 30, 2023 15:32
@samaloney
Copy link
Collaborator Author

E2E differences look as expected to me but 2nd look would be good.

Copy link
Collaborator

@nicHoch nicHoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good

@nicHoch nicHoch merged commit a801e54 into i4Ds:master Dec 7, 2023
1 check failed
@samaloney samaloney deleted the bugfix-carrington-lon branch March 21, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants