Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docu #636

Merged
merged 15 commits into from
Dec 18, 2024
Merged

Update Docu #636

merged 15 commits into from
Dec 18, 2024

Conversation

anawas
Copy link
Collaborator

@anawas anawas commented Dec 17, 2024

This pull request updates the documentation. Three things were done or fixed:

  1. It addresses the comment of @mpluess to the closed issue Publicly runnable example notebook exists #556. I added a reference and a note to the Karabo workshop on Renkulab both in the README and the documentation.
  2. I added documentation pages for the Karabo.imaging module.
  3. I fixed some of the worst formatting issues in the documentation pages. But there is still a lot of work to do.

@anawas anawas requested a review from mpluess December 17, 2024 10:28
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.19%. Comparing base (30fa377) to head (c8a028a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #636   +/-   ##
=======================================
  Coverage   71.19%   71.19%           
=======================================
  Files          55       55           
  Lines        5946     5946           
=======================================
  Hits         4233     4233           
  Misses       1713     1713           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anawas anawas merged commit 1da8116 into main Dec 18, 2024
3 checks passed
@anawas anawas deleted the aw_update_docu branch December 18, 2024 14:23
Copy link
Member

@mpluess mpluess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anawas Nice work to improve the documentation, generally speaking. Some points to be addressed. Also, is there a reason why this was merged without a prior review?

doc/src/index.rst Show resolved Hide resolved
karabo/imaging/imager_base.py Show resolved Hide resolved
restore step (none, linear or tukey). Defaults to "tukey".
clean_restored_output (CleanRestoredOutputType): Type of restored image output:
taylor, list, or integrated. Defaults to "list".
:param imaging_npixel: see ImageCleanerConfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason to change the docstring format here? Switching to a unified docstring format and checking the format on-commit is an open issue, but this would require a fair amount of work.

Might be useful for reading larger-than-memory .fits files.
memmap: Whether to use memory mapping when opening the FITS file.
Allows for reading of larger-than-memory files.
:param fits_file: The .fits file to create the sky-model from.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for docstring format change? (see comment above)


Returns:
.tm file-path & station-name conversion (e.g. station055 -> station009)
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason for docstring format change? (see above)

@@ -117,7 +117,7 @@ def detect_sources_in_image(

Parameters
----------
cls : Type[_SourceDetectionResultType]
cls : Type[SourceDetectionResultType]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reverted, refers to _SourceDetectionResultType defined on line 258

Additional keyword arguments to pass to PyBDSF.process_image function.

Returns
-------
Optional[List[_SourceDetectionResultType]]
Optional[List[SourceDetectionResultType]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reverted, refers to _SourceDetectionResultType defined on line 258

@anawas anawas restored the aw_update_docu branch December 20, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants