-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docu #636
Update Docu #636
Conversation
… The changes were made in the wrong file. This reverts commit 50e885f.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
=======================================
Coverage 71.19% 71.19%
=======================================
Files 55 55
Lines 5946 5946
=======================================
Hits 4233 4233
Misses 1713 1713 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anawas Nice work to improve the documentation, generally speaking. Some points to be addressed. Also, is there a reason why this was merged without a prior review?
restore step (none, linear or tukey). Defaults to "tukey". | ||
clean_restored_output (CleanRestoredOutputType): Type of restored image output: | ||
taylor, list, or integrated. Defaults to "list". | ||
:param imaging_npixel: see ImageCleanerConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason to change the docstring format here? Switching to a unified docstring format and checking the format on-commit is an open issue, but this would require a fair amount of work.
Might be useful for reading larger-than-memory .fits files. | ||
memmap: Whether to use memory mapping when opening the FITS file. | ||
Allows for reading of larger-than-memory files. | ||
:param fits_file: The .fits file to create the sky-model from. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason for docstring format change? (see comment above)
|
||
Returns: | ||
.tm file-path & station-name conversion (e.g. station055 -> station009) | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason for docstring format change? (see above)
@@ -117,7 +117,7 @@ def detect_sources_in_image( | |||
|
|||
Parameters | |||
---------- | |||
cls : Type[_SourceDetectionResultType] | |||
cls : Type[SourceDetectionResultType] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be reverted, refers to _SourceDetectionResultType defined on line 258
Additional keyword arguments to pass to PyBDSF.process_image function. | ||
|
||
Returns | ||
------- | ||
Optional[List[_SourceDetectionResultType]] | ||
Optional[List[SourceDetectionResultType]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be reverted, refers to _SourceDetectionResultType defined on line 258
This pull request updates the documentation. Three things were done or fixed:
Karabo.imaging
module.