Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vt parallise source detection #523

Merged
merged 37 commits into from
Nov 23, 2023
Merged

Vt parallise source detection #523

merged 37 commits into from
Nov 23, 2023

Conversation

kenfus
Copy link
Member

@kenfus kenfus commented Nov 3, 2023

  • Adds parallized source detection
  • Adds functionality to split a karabo.image into multiple parts
  • Adds mosaicking for source detection plots
  • General improvements of the karabo image class

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (f1e3cc2) 72.91% compared to head (94b8fa9) 74.96%.

Files Patch % Lines
karabo/sourcedetection/result.py 75.00% 39 Missing ⚠️
karabo/imaging/image.py 96.34% 3 Missing ⚠️
karabo/util/dask.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   72.91%   74.96%   +2.04%     
==========================================
  Files          35       35              
  Lines        3652     3859     +207     
==========================================
+ Hits         2663     2893     +230     
+ Misses        989      966      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kenfus kenfus requested a review from Lukas113 November 15, 2023 13:14
Copy link
Collaborator

@Lukas113 Lukas113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice changes.

Before merging, please address the requested changes.

karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/sourcedetection/result.py Outdated Show resolved Hide resolved
karabo/sourcedetection/result.py Show resolved Hide resolved
karabo/sourcedetection/result.py Outdated Show resolved Hide resolved
karabo/sourcedetection/result.py Outdated Show resolved Hide resolved
karabo/test/data/restored.fits Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/test/data/restored.fits Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/test/test_image.py Show resolved Hide resolved
@kenfus
Copy link
Member Author

kenfus commented Nov 22, 2023

Overall nice changes.

Before merging, please address the requested changes.

Done! Please have another look.

karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/imaging/image.py Outdated Show resolved Hide resolved
karabo/sourcedetection/result.py Outdated Show resolved Hide resolved
karabo/sourcedetection/result.py Show resolved Hide resolved
karabo/sourcedetection/result.py Show resolved Hide resolved
karabo/sourcedetection/result.py Outdated Show resolved Hide resolved
karabo/sourcedetection/result.py Outdated Show resolved Hide resolved
@kenfus
Copy link
Member Author

kenfus commented Nov 22, 2023

@Lukas113 Please have another look. I would like to later restructure source detection completely, see #528

Copy link
Collaborator

@Lukas113 Lukas113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@Lukas113 Lukas113 merged commit abbed18 into main Nov 23, 2023
3 checks passed
@Lukas113 Lukas113 deleted the VT_parallise_source_detection branch November 23, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants