Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for Line Emission #520

Merged
merged 10 commits into from
Oct 19, 2023
Merged

Conversation

lmachadopolettivalle
Copy link
Collaborator

  • Improve documentation in line emission example notebook
  • Rerun script to verify it runs end to end

Copy link
Member

@sfiruch sfiruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not skip tests, especially not this one.

The idea of this test, was to have a very simple PINOCCHIO run, small enough that it can complete on GH runners. If it's still to slow, we should reconfigure it instead.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eaaeb53) 73.84% compared to head (6f9821d) 70.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   73.84%   70.61%   -3.23%     
==========================================
  Files          35       35              
  Lines        3907     3907              
==========================================
- Hits         2885     2759     -126     
- Misses       1022     1148     +126     
Files Coverage Δ
karabo/version.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lmachadopolettivalle
Copy link
Collaborator Author

@deiruch Since we agreed on removing PINOCCHIO, I have skipped its test for this PR. Once this is merged, I will submit a new PR for the removal of the code and its tests.

Copy link
Collaborator

@Lukas113 Lukas113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Lukas113 Lukas113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved since we agreed to remove pinocchio.

@Lukas113 Lukas113 merged commit c397778 into main Oct 19, 2023
3 checks passed
@Lukas113 Lukas113 deleted the LFMPV_improveHDF5Reading branch October 19, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants