-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation for Line Emission #520
Conversation
lmachadopolettivalle
commented
Oct 10, 2023
- Improve documentation in line emission example notebook
- Rerun script to verify it runs end to end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not skip tests, especially not this one.
The idea of this test, was to have a very simple PINOCCHIO run, small enough that it can complete on GH runners. If it's still to slow, we should reconfigure it instead.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 73.84% 70.61% -3.23%
==========================================
Files 35 35
Lines 3907 3907
==========================================
- Hits 2885 2759 -126
- Misses 1022 1148 +126
☔ View full report in Codecov by Sentry. |
@deiruch Since we agreed on removing PINOCCHIO, I have skipped its test for this PR. Once this is merged, I will submit a new PR for the removal of the code and its tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved since we agreed to remove pinocchio.