Remove PINOCCHIO from dependencies (#521)

* Remove Python class and tests for PINOCCHIO * Remove PINOCCHIO from dependency list
i4Ds · Oct 19, 2023 · 2bb1733 · 2bb1733
1 parent c397778
commit 2bb1733
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 831 deletions.
diff --git a/README.md b/README.md
@@ -11,7 +11,7 @@
 
 Karabo is a radio astronomy software distribution for validation and benchmarking of radio telescopes and algorithms. It can be used to simulate the behaviour of the [Square Kilometer Array](https://www.skatelescope.org/the-ska-project/). Our goal is to make installation and ramp-up easier for researchers and developers.
 
-Karabo includes and relies on OSKAR, RASCIL, Pinocchio (a Dark Matter halo simulation), PyBDSF, [MIGHTEE](https://arxiv.org/abs/2211.05741), [GLEAM](https://www.mwatelescope.org/science/galactic-science/gleam/), Aratmospy, Bluebild, Eidos, Dask, Tools21cm, katbeam plus configuration of 20 well-known telescopes. Karabo can simulate instrument behavior and atmospheric effects, run imaging algorithms, and evaluate results.
+Karabo includes and relies on OSKAR, RASCIL, PyBDSF, [MIGHTEE](https://arxiv.org/abs/2211.05741), [GLEAM](https://www.mwatelescope.org/science/galactic-science/gleam/), Aratmospy, Bluebild, Eidos, Dask, Tools21cm, katbeam plus configuration of 20 well-known telescopes. Karabo can simulate instrument behavior and atmospheric effects, run imaging algorithms, and evaluate results.
 
 <img src="https://github.com/i4Ds/Karabo-Pipeline/assets/4119188/1b5086c4-9df7-4732-a832-89fdbd8abba9" width="50%" />
 

diff --git a/conda/meta.yaml b/conda/meta.yaml
@@ -38,7 +38,6 @@ requirements:
     - numpy=1.22
     - oskarpy=2.8.3
     - pandas
-    - pinocchio=5.0.0
     - psutil
     - rascil=1.0.0
     - reproject

diff --git a/environment.yaml b/environment.yaml
@@ -25,7 +25,6 @@ dependencies:
   - numpy=1.22
   - oskarpy=2.8.3
   - pandas
-  - pinocchio=5.0.0
   - psutil
   - rascil=1.0.0
   - reproject

diff --git a/karabo/error.py b/karabo/error.py
@@ -16,10 +16,6 @@ class KaraboSkyModelError(KaraboError):
     ...
 
 
-class KaraboPinocchioError(KaraboError):
-    ...
-
-
 class KaraboSourceDetectionEvaluationError(KaraboError):
     ...
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,10 +16,6 @@ class KaraboSkyModelError(KaraboError): @@
         ...
-    class KaraboPinocchioError(KaraboError):
-        ...
     class KaraboSourceDetectionEvaluationError(KaraboError):
         ...
@@ Expand Down @@