fixed table sizing with length of notes #68
Conversation
src/App.tsx
Outdated
There was a problem hiding this comment.
You should look at how the main branch deals with utilizing main.tsx! We decided to add in new pages for changelog and documentation so this will be helpful in understanding the frontend structure :)
(so basically we are not using App.tsx anymore and it should be deleted!)
src/components/DataTable.tsx
Outdated
| <Input.Wrapper> | ||
| <Textarea | ||
| variant="unstyled" | ||
| value=" |
There was a problem hiding this comment.
Change this back to file.note
src/components/DataTable.tsx
Outdated
| style={{ whiteSpace: "normal", wordWrap: "break-word" }} | ||
| readOnly | ||
| placeholder="Note" | ||
| rows={4} |
There was a problem hiding this comment.
Can you avoid hard coding the amount of rows? Maybe make it dynamic?
src/components/DataTable.tsx
Outdated
| // now with four rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows rows" | ||
| style={{ whiteSpace: "normal", wordWrap: "break-word" }} | ||
| readOnly | ||
| placeholder="Note" |
There was a problem hiding this comment.
Maybe change this to No notes available?
something like down below
| <Table.Td style={{ paddingRight: "25px" }}> | ||
| <Input.Wrapper> | ||
| <Textarea | ||
| variant="unstyled" |
There was a problem hiding this comment.
Can you add size="xs" to this as well as the location?
| <Table.Td>{getFileNameWithoutExtension(file.mcap_files[0].file_name)}</Table.Td> | ||
| <Table.Td style={{ paddingLeft: "25px" }}> | ||
| {getFileNameWithoutExtension(file.mcap_files[0].file_name)} | ||
| </Table.Td> | ||
| <Table.Td>{file.date}</Table.Td> | ||
| <Table.Td>{file.location}</Table.Td> |
There was a problem hiding this comment.
Can u do the same for location but with maxRows of 1?
| } | ||
|
|
||
| .table-contain-result { | ||
| flex-grow: 1; | ||
| overflow-y: auto; | ||
| padding-bottom: 10px; | ||
| } | ||
| width: 80%; |
There was a problem hiding this comment.
can u make this 60% (also min-width)
| @@ -4,7 +4,7 @@ | |||
| font-size: 15px; | |||
| overflow: auto; | |||
| padding-bottom: 10px; | |||
| border-left: solid #D1BF80 2px; | |||
| @@ -21,7 +21,7 @@ | |||
| "@mantine/hooks": "^7.13.1", | |||
| "@tabler/icons-react": "3.17.0", | |||
| "dayjs": "^1.11.13", | |||
| "nuqs": "^2.2.1", | |||
There was a problem hiding this comment.
Might want to change this back. Im not sure if this was the exact issue but application might be loading slower because of this
No description provided.