animation: add virtual dtor to AnimationManager #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
considering it's not that important, will merge once there is another abi break |
PaideiaDilemma
force-pushed
the
main
branch
3 times, most recently
from
70b4581 to
5e5ab83
Compare
|
why do all tests fail lol @PaideiaDilemma |
|
i acidentally pushed on the branch and then rebased it onto broken ci. one sec |
This was referenced Jan 18, 2025
So does that mean that you aren't deleting any subclasses of CAnimationManager via a pointer to the base CAnimationManager class (either directly or via a "smart" pointer's destructor)? |
|
nope. All hypr* stuff use CAnimationManager as a global |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.