fix: links and references to Atala in the quick-start.md guide #95
Conversation
…ve all refereces fixed)
todorkoleviohk
changed the title
There was a problem hiding this comment.
Quick Start Guide renaming is not finished. Please align with @CryptoKnightIOG and his PR #96. And pair together to finish this.
src/components/resources/index.js
Outdated
| @@ -129,13 +129,13 @@ const RESOURCES = [ | |||
| title: "Wallet SDK Swift", | |||
| Svg: Graphics.walletSdkSwift, | |||
| content: "Build Swift-based applications using our SDKs", | |||
| linkTo: "https://input-output-hk.github.io/atala-prism-wallet-sdk-swift/" | |||
| linkTo: "https://input-output-hk.github.io/atala-prism-wallet-sdk-swift/documentation/atalaprismsdk/" | |||
There was a problem hiding this comment.
Could you explain why changing the path? The swift SDK is working well in the current staging website. It was changed to https://input-output-hk.github.io/atala-prism-wallet-sdk-swift/documentation/edgeagentsdk/ in the PR #93
There was a problem hiding this comment.
reverted back to original link, we will do a link check in second iteration.
There was a problem hiding this comment.
src/components/resources/index.js
Outdated
| }, | ||
| { | ||
| title: "Wallet SDK TypeScript", | ||
| Svg: Graphics.walletSdkTS, | ||
| content: "Build web-based applications using our SDKs", | ||
| linkTo: "#" | ||
| linkTo: "https://input-output-hk.github.io/atala-prism-wallet-sdk-ts/" |
There was a problem hiding this comment.
Please explain the reason of this link change. So we are sure it is not breaking something somewhere else.
There was a problem hiding this comment.
reverted back to original link, we will do a link check in second iteration.
There was a problem hiding this comment.
"#" must have been a placeholder from early days before the repo was actually ready :)
This doesn't lead to anywhere and changing it to a good link does not incur a risk of breaking.
src/components/resources/index.js
Outdated
| @@ -129,13 +129,13 @@ const RESOURCES = [ | |||
| title: "Wallet SDK Swift", | |||
| Svg: Graphics.walletSdkSwift, | |||
| content: "Build Swift-based applications using our SDKs", | |||
| linkTo: "https://input-output-hk.github.io/atala-prism-wallet-sdk-swift/" | |||
| linkTo: "https://input-output-hk.github.io/atala-prism-wallet-sdk-swift/documentation/atalaprismsdk/" | |||
| }, | |||
| { | |||
| title: "Wallet SDK TypeScript", | |||
There was a problem hiding this comment.
to Edge Agent SDK TypeScript or Edge Agent SDK TS
src/components/resources/index.js
Outdated
| }, | ||
| { | ||
| title: "Wallet SDK TypeScript", | ||
| Svg: Graphics.walletSdkTS, | ||
| content: "Build web-based applications using our SDKs", | ||
| linkTo: "#" | ||
| linkTo: "https://input-output-hk.github.io/atala-prism-wallet-sdk-ts/" | ||
| }, | ||
| { | ||
| title: "Wallet SDK KMM", |
There was a problem hiding this comment.
To Edge Agent SDK KMP
And Build KMP-based
documentation/docs/quick-start.md
Outdated
| @@ -54,7 +54,7 @@ More in-depth documentation about the different Wallet SDKs can be found here ([ | |||
| More in-depth documentation about PRISM Mediator can be found [here](/docs/atala-prism/prism-mediator). | |||
|
|
|||
| #### A Node for a Verifiable Data Registry (VDR) | |||
| To issue and verify VCs to and from DIDs, we need a [Verifiable Data Registry (VDR)](/docs/concepts/glossary/#verifiable-data-registry) that is globally resolvable and always on. In PRISM's case, it is `prism-node`, [anchoring](/docs/concepts/glossary/#anchoring) key information required for issuance and verification on the Cardano blockchain. | |||
| To issue and verify VCs to and from DIDs, we need a [Verifiable Data Registry (VDR)](/docs/concepts/glossary/#verifiable-data-registry) that is globally resolvable and always on. In PRISM's case, it is `prism-node`, [anchoring](/docs/concepts/glossary/#anchoring) key information required for issuance and verification on the Distributed Ledger blockchain. | |||
There was a problem hiding this comment.
@todorkoleviohk , in the Quick Start Guide, there are more to update: the links to the old repo hyperledger lab, the Wallet to Edge Agent.
I advise you to review what @CryptoKnightIOG has done in this PR #96 and work together to finish it.
Also, you have modified some paths to generate, and not sure in which case it was not working. Please give background for those changes so we can make a decision.
Signed-off-by: Bassam Riman <[email protected]>
|
Had to open a new one as this one was far too much behind and was messy already. |
https://input-output.atlassian.net/browse/ATL-7064
This is a non-conflicting merge of changes made before some other changes were merged from other branches.
Please let's merge this one and then we look into the other open PR's, merge and then final overhaul to make sure all fixes are in and everything is correct.
I have an automated tool to check that all links work and all replacement table is applied.