fix: Status call returns properly when node is not registered but organisation is #1467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1453 and this change
When a namespace is registered to the organisation but the node has not been registered, if the name has not been set (i.e. it's
""
) then we throw an error. If a name is set, then we returnnil
because while there is no information on the node (as it's not registered) it is possible for the node to be registered.Side note: getting an environment in which to test this was a colossal pain and largely undocumented, so I'm going to put a comment below with how I got a testing configuration in place to test this out.