Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Use besu-untuned to execute the acceptance tests #7340

Closed

Conversation

ahamlat
Copy link
Contributor

@ahamlat ahamlat commented Jul 17, 2024

PR description

Use besu-untuned to execute different tests that need to run a besu node in a different process.
Also, there is no need to apply the JVM tuning related to GC and continuous profiling to this kind of tests.

image

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

…u node (ex. acceptance tests)

Signed-off-by: Ameziane H <[email protected]>
@ahamlat ahamlat marked this pull request as ready for review July 17, 2024 15:32
macfarla
macfarla previously approved these changes Jul 17, 2024
@macfarla
Copy link
Contributor

It's different test failures each time but it seems specific to this PR (eg CLIOptions tests)

@ahamlat
Copy link
Contributor Author

ahamlat commented Jul 19, 2024

Yes, it seems to be related to this PR, I tried different executions but I had different issues especially the timeout one. My interpretation is that with besu sh, the acceptance tests are running faster. The only difference between besu and besu-untuned is GC flags and JFR continuous profiling.
I will continue to investigate.

@ahamlat ahamlat changed the title Use besu-untuned to execute the acceptance tests [DO NOT MERGE] Use besu-untuned to execute the acceptance tests Jul 30, 2024
@macfarla macfarla marked this pull request as draft August 1, 2024 02:37
@macfarla macfarla dismissed their stale review October 1, 2024 21:47

not intended for merge

@ahamlat ahamlat closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants