Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #6481

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Fix typos #6481

merged 3 commits into from
Jan 29, 2024

Conversation

Thabokani
Copy link
Contributor

PR description

Fix typos in comments.

Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

@macfarla
Copy link
Contributor

@Thabokani thanks for your contribution - we can merge this if you add signoff to your commits - follow the instructions here - to make the DCO check pass

Signed-off-by: Thabokani <[email protected]>
@Thabokani
Copy link
Contributor Author

@Thabokani thanks for your contribution - we can merge this if you add signoff to your commits - follow the instructions here - to make the DCO check pass

@macfarla thanks for your review. I have added signoff.

@macfarla
Copy link
Contributor

ok one more thing to fix - I don't have permissions to update your branch otherwise I'd do it for you - but the plugin-api hash needs updating - instructions here - that's why the unit tests are failing https://app.circleci.com/pipelines/github/hyperledger/besu/26758/workflows/0246a9b0-4020-414d-a270-3eb6027d82ba/jobs/176846

@macfarla
Copy link
Contributor

Thanks for persevering @Thabokani - should merge shortly!

@macfarla macfarla enabled auto-merge (squash) January 29, 2024 07:29
@macfarla macfarla merged commit f125aed into hyperledger:main Jan 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants