Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] - Extract JsonRpcHttpOptions to a new class #6478

Merged
merged 8 commits into from
Jan 29, 2024
Merged

[Refactor] - Extract JsonRpcHttpOptions to a new class #6478

merged 8 commits into from
Jan 29, 2024

Conversation

Gabriel-Trintinalia
Copy link
Contributor

PR description

[Refactor] - Extract JsonRpcHttpOptions to a new class

Moves the JsonRpcHttpOptions cli options to its own class.
same for related tests

see #6428

@Gabriel-Trintinalia
Move JsonRpcHttpOptions to its onw class
2eb30fe 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
fix unit test
d7e3b8b 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix headers
de1c431 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited by Gabriel-Trintinalia
Loading

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

pinges
pinges approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gabriel-Trintinalia Gabriel-Trintinalia enabled auto-merge (squash) January 29, 2024 02:40
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit e55569c into hyperledger:main Jan 29, 2024
18 checks passed
@Gabriel-Trintinalia Gabriel-Trintinalia deleted the 6428-json-http-options branch January 23, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinges pinges pinges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gabriel-Trintinalia @pinges @macfarla