Snap sync client handle empty final account storage ranges #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
garyschulte
force-pushed
the
bugfix/snap-empty-storage-ranges
branch
2 times, most recently
from
85cb6ab to
73291e1
Compare
garyschulte
force-pushed
the
bugfix/snap-empty-storage-ranges
branch
from
73291e1 to
b5a594c
Compare
matkt
requested changes
Dec 20, 2023
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/PersistDataStep.java
Outdated
Show resolved
Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/RequestDataStep.java
Outdated
Show resolved
Hide resolved
ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/StackTrie.java
Outdated
Show resolved
Hide resolved
| && Arrays.compare(location.toArrayUnsafe(), endKeyHash.toArrayUnsafe()) <= 0; | ||
| return location.isEmpty() | ||
| || (Arrays.compare(location.toArrayUnsafe(), startKeyHash.toArrayUnsafe()) >= 0 | ||
| && Arrays.compare(location.toArrayUnsafe(), endKeyHash.toArrayUnsafe()) <= 0); |
garyschulte
force-pushed
the
bugfix/snap-empty-storage-ranges
branch
3 times, most recently
from
7cff6d0 to
d1abab6
Compare
…as complete Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…avoid throwing MerkleTrieException for failed lookups Signed-off-by: garyschulte <[email protected]>
…roken persist test Signed-off-by: garyschulte <[email protected]>
…hen the proof is valid and empty (request was complete) Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
garyschulte
force-pushed
the
bugfix/snap-empty-storage-ranges
branch
from
d1abab6 to
a35239a
Compare
|
superseded by #6847 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Bugfix snap sync edge case. When snap syncing large contract storage, if the final requested range is empty, but there is an accompanying proof of exclusion, besu will not mark the request complete and will endlessly retry.
This PR handles this case by marking the request complete as long as there is an accompanying proof
Fixed Issue(s)