[MINOR] move Pipeline stack trace to trace/debug level #6222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <[email protected]>
|
macfarla
changed the title
jframe
approved these changes
Dec 1, 2023
| } else { | ||
| LOG.info("Unexpected exception in pipeline. Aborting.", t); | ||
| LOG.info("Unexpected exception in pipeline. Aborting."); | ||
| LOG.debug("Unexpected exception in pipeline. Aborting.", t); |
There was a problem hiding this comment.
nit: little annoying most of the log message except for the throwable will be logged twice once at info and also at trace level. But it's only a short message and at trace, you expect a lot of noise so it's probably fine.
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Sally MacFarlane <[email protected]>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 4, 2023
Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Justin Florentine <[email protected]>
gfukushima
pushed a commit
to gfukushima/besu
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel Fukushima <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log a message only at info
log stack trace at debug/trace depending on type of exception
fixes #5533