closeHandler has to be registered before connection close

Signed-off-by: Wetitpig <[email protected]>
hyperledger · Dec 7, 2023 · 73bb10a · 73bb10a
1 parent 398cfa2
commit 73bb10a
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/...m/api/src/main/java/org/hyperledger/besu/ethereum/api/handlers/MaxConnectionsHandler.java b/...m/api/src/main/java/org/hyperledger/besu/ethereum/api/handlers/MaxConnectionsHandler.java
@@ -29,6 +29,14 @@ private MaxConnectionsHandler() {}
   public static Handler<HttpConnection> handler(
       final AtomicInteger activeConnectionsCount, final int maxActiveConnections) {
     return connection -> {
+      connection.closeHandler(
+          c ->
+              LOG.debug(
+                  "Connection closed from {} to {}. Total of active connections: {}/{}",
+                  connection.remoteAddress(),
+                  connection.localAddress(),
+                  activeConnectionsCount.decrementAndGet(),
+                  maxActiveConnections));
       if (activeConnectionsCount.get() >= maxActiveConnections) {
         // disallow new connections to prevent DoS
         LOG.warn(
@@ -45,14 +53,6 @@ public static Handler<HttpConnection> handler(
             activeConnectionsCount.incrementAndGet(),
             maxActiveConnections);
       }
-      connection.closeHandler(
-          c ->
-              LOG.debug(
-                  "Connection closed from {} to {}. Total of active connections: {}/{}",
-                  connection.remoteAddress(),
-                  connection.localAddress(),
-                  activeConnectionsCount.decrementAndGet(),
-                  maxActiveConnections));
     };
   }
 }