Fix unit tests, remove DeterministicEthScheduler for trace tests as i…

…t not performant enough Signed-off-by: Ameziane H. <[email protected]>
hyperledger · Jan 9, 2025 · 447907b · 447907b
1 parent bc433e5
commit 447907b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...a/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/DebugTraceBlockByNumber.java b/...a/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/DebugTraceBlockByNumber.java
@@ -153,6 +153,6 @@ protected Object resultByBlockNumber(
                       }
                       return Optional.of(tracesList);
                     }))
-        .orElse(Collections.emptyList());
+        .orElse(null);
   }
 }
diff --git a/...c/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/AbstractJsonRpcHttpServiceTest.java b/...c/test/java/org/hyperledger/besu/ethereum/api/jsonrpc/AbstractJsonRpcHttpServiceTest.java
@@ -42,6 +42,7 @@
 import org.hyperledger.besu.ethereum.core.Transaction;
 import org.hyperledger.besu.ethereum.eth.EthProtocol;
 import org.hyperledger.besu.ethereum.eth.manager.EthPeers;
+import org.hyperledger.besu.ethereum.eth.manager.EthScheduler;
 import org.hyperledger.besu.ethereum.eth.transactions.TransactionPool;
 import org.hyperledger.besu.ethereum.mainnet.ValidationResult;
 import org.hyperledger.besu.ethereum.p2p.network.P2PNetwork;
@@ -53,7 +54,6 @@
 import org.hyperledger.besu.nat.NatService;
 import org.hyperledger.besu.plugin.services.storage.DataStorageFormat;
 import org.hyperledger.besu.testutil.BlockTestUtil.ChainResources;
-import org.hyperledger.besu.testutil.DeterministicEthScheduler;
 
 import java.math.BigInteger;
 import java.net.URL;
@@ -216,7 +216,7 @@ protected Map<String, JsonRpcMethod> getRpcMethods(
             mock(ApiConfiguration.class),
             Optional.empty(),
             transactionSimulator,
-            new DeterministicEthScheduler());
+            new EthScheduler(1, 1, 1, new NoOpMetricsSystem()));
   }
 
   protected void startService() throws Exception {