Integration test with multiple aca-py agents #13

ianco · 2021-12-14T04:37:55Z

Test connection process between 2 agents.

New base class for integration testing with multiple agents.

Parametrize agent startup to allow different tests to start agents with different settings.

Add test with author/endorser flow.

Signed-off-by: Ian Costanzo <[email protected]>

etschelp · 2022-01-04T10:35:35Z

src/test/java/org/hyperledger/aries/api/connection/EndorserConnectionRecordTest.java

+        assertTrue(conn2_updated.isPresent());
+
+        // pause to allow the agent chatter to complete
+        Thread.sleep(4000);


Thread.sleep() is something that is never good in any test. As it slows down each test execution and is not portable between machines. If there is really no other way it is better to have a waiting condition with a callback that checks for the expected change and fails if the change does not happen in a certain amount of time.

etschelp · 2022-01-04T10:51:11Z

src/test/java/org/hyperledger/aries/api/connection/MultiConnectionRecordTest.java

+import static org.junit.jupiter.api.Assertions.*;
+
+@Slf4j
+public class MultiConnectionRecordTest extends MultiIntegrationTestBase {


As these tests are integration tests they should not run together with the other tests. To achieve that I would recommend using the @Tag("IntegrationTest") annotation together with a filter in the surefire plugin:

<plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-surefire-plugin</artifactId> <version>3.0.0-M5</version> <configuration> <excludedGroups>IntegrationTest</excludedGroups> </configuration> </plugin>

To run the integration tests only one can either add a profile to the pom or do this via the command line e.g. mvn test -Dgroups=IntegrationTest

etschelp · 2022-01-04T10:57:07Z

src/test/java/org/hyperledger/aries/api/connection/EndorserConnectionRecordTest.java

+@Slf4j
+public class EndorserConnectionRecordTest extends MultiIntegrationTestBase {
+
+    public static final String INDY_LEDGER_URL = "https://indy-test.bosch-digital.de";


How complicated is it to start a indy node via a test container? This would probably be the best solution instead of relying to an external service that we wanted to turn off a while ago.

etschelp · 2022-01-04T11:00:21Z

src/test/java/org/hyperledger/aries/MultiIntegrationTestBase.java

+            .withLogConsumer(new Slf4jLogConsumer(log))
+            ;
+
+    protected String extraAgentArgs(int agentNum) {


The api is a bit confusing, I would also make that method abstract.

And I would split this up into two abstract methods like agentOneArgs() and agentTwoArgs, then you do not have to use switches all the time

etschelp · 2022-01-04T11:15:38Z

src/test/java/org/hyperledger/aries/LedgerClient.java

+                .post(jsonBody(gson.toJson(body)))
+                .build();
+    }
+


Dead code below

etschelp · 2022-01-04T11:20:12Z

src/test/java/org/hyperledger/aries/api/connection/EndorserConnectionRecordTest.java

+                    .alias(alias_1)
+                    .did(localDid1.getDid())
+                    .verkey(localDid1.getVerkey())
+                    .build());


I like using orElseThrow() in these cases, makes it cleaner to read.

etschelp · 2022-01-04T11:27:17Z

src/test/java/org/hyperledger/aries/util/ledger/LedgerDIDCreate.java

+@lombok.NoArgsConstructor
+@lombok.Builder
+public class LedgerDIDCreate {
+    public static final String SERIALIZED_NAME_ALIAS = "alias";


using @SerialisedName here is redundant

etschelp · 2022-01-04T11:29:17Z

src/test/java/org/hyperledger/aries/util/ledger/LedgerDIDCreate.java

+@lombok.AllArgsConstructor
+@lombok.NoArgsConstructor
+@lombok.Builder
+public class LedgerDIDCreate {


Make these two inner classes of the LedgerClient?

etschelp · 2022-01-04T11:30:48Z

src/test/java/org/hyperledger/aries/LedgerClient.java

+ */
+@Slf4j
+@SuppressWarnings("unused")
+public class LedgerClient extends BaseClient {


Would be useful to have this in the main package

etschelp · 2022-01-04T11:31:24Z

src/test/java/org/hyperledger/aries/util/ledger/LedgerDIDResponse.java

+@lombok.Builder
+public class LedgerDIDResponse {
+    public static final String SERIALIZED_NAME_DID = "did";
+    @SerializedName(SERIALIZED_NAME_DID)


Same as above

Signed-off-by: Ian Costanzo <[email protected]>

ianco · 2022-01-19T16:30:45Z

@etschelp the build for this PR is failing with a license check, however it look like I've included the license header in each of these files, any suggestions?

[INFO] --- license-maven-plugin:4.1:check (default) @ aries-client-python ---
[INFO] Checking licenses...
Warning:  Missing header in: /home/runner/work/acapy-java-client/acapy-java-client/src/test/java/org/hyperledger/aries/api/connection/EndorserConnectionRecordTest.java
Warning:  Missing header in: /home/runner/work/acapy-java-client/acapy-java-client/src/test/java/org/hyperledger/aries/api/connection/MultiConnectionRecordTest.java
Warning:  Missing header in: /home/runner/work/acapy-java-client/acapy-java-client/src/test/java/org/hyperledger/aries/LedgerClient.java
Warning:  Missing header in: /home/runner/work/acapy-java-client/acapy-java-client/src/test/java/org/hyperledger/aries/MultiIntegrationTestBase.java
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  04:17 min
[INFO] Finished at: 2022-01-13T17:08:11Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal com.mycila:license-maven-plugin:4.1:check (default) on project aries-client-python: Some files do not have the expected license header -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error: Process completed with exit code 1.

etschelp · 2022-01-19T16:56:44Z

@ianco simply run mvn license:format once and then push the changes.

Signed-off-by: Ian Costanzo <[email protected]>

ianco · 2022-01-19T17:16:34Z

@ianco simply run mvn license:format once and then push the changes.

Awesome thanks for the tip!

ianco added 5 commits December 13, 2021 20:28

Multi-agent integration test

ccdc49e

Signed-off-by: Ian Costanzo <[email protected]>

Fix typos

67bdf2f

Signed-off-by: Ian Costanzo <[email protected]>

Parametrize agent startup args by test

33474db

Signed-off-by: Ian Costanzo <[email protected]>

Add ledger service (create DIDs), initial endorser test WIP

324aae1

Signed-off-by: Ian Costanzo <[email protected]>

Test author/endorser flow with auto flags

901af34

Signed-off-by: Ian Costanzo <[email protected]>

ianco marked this pull request as ready for review December 14, 2021 20:42

Didexchange connection integration tests

bc3a8b4

Signed-off-by: Ian Costanzo <[email protected]>

ianco requested a review from etschelp December 21, 2021 17:34

etschelp suggested changes Jan 4, 2022

View reviewed changes

Merge remote-tracking branch 'upstream/main' into multi_test

78f55ac

ianco marked this pull request as draft January 13, 2022 16:38

Updates from PR feedback

e674b4a

Signed-off-by: Ian Costanzo <[email protected]>

Fix license headers

5d1f4ea

Signed-off-by: Ian Costanzo <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integration test with multiple aca-py agents #13

Integration test with multiple aca-py agents #13

ianco commented Dec 14, 2021 •

edited

Loading

etschelp Jan 4, 2022

etschelp Jan 4, 2022

etschelp Jan 4, 2022

etschelp Jan 4, 2022

etschelp Jan 4, 2022

etschelp Jan 4, 2022

etschelp Jan 4, 2022

etschelp Jan 4, 2022

etschelp Jan 4, 2022

etschelp Jan 4, 2022

etschelp Jan 4, 2022

ianco commented Jan 19, 2022

etschelp commented Jan 19, 2022

ianco commented Jan 19, 2022

Integration test with multiple aca-py agents #13

Are you sure you want to change the base?

Integration test with multiple aca-py agents #13

Conversation

ianco commented Dec 14, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ianco commented Jan 19, 2022

etschelp commented Jan 19, 2022

ianco commented Jan 19, 2022

ianco commented Dec 14, 2021 •

edited

Loading