Rewrite Crypto WASM using the original iroha_crypto crate
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo check --target wasm32-unknown-unknown` fails: `getrandom` crate features are invalid Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
0x009922
force-pushed
the
iroha2-upstream-crypto
branch
from
728d793 to
098226e
Compare
0x009922
commented
Mar 5, 2024
|
I don't know that much about |
Signed-off-by: Dmitry Balashov <[email protected]>
|
@DCNick3, thanks! |
|
This PR needs to update due to merge of hyperledger-iroha/iroha#4341 |
Signed-off-by: Dmitry Balashov <[email protected]>
Signed-off-by: Dmitry Balashov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186
See changesets and the issue for context.
Additionally, I have significantly extended integration tests around crypto.