-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: integratin presentation exchange SDJWT verification with disclosures #388
fix: integratin presentation exchange SDJWT verification with disclosures #388
Conversation
…ure frames Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Pull Request Test Coverage Report for Build 13570729507Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@@ -73,7 +73,7 @@ export class CreateJWT extends Task<string, Args> { | |||
* @param privateKey | |||
* @returns {string} kid (key identifier) | |||
*/ | |||
private async getSigningKid(ctx: Task.Context, did: Domain.DID, privateKey: Domain.PrivateKey) { | |||
async getSigningKid(ctx: Task.Context, did: Domain.DID, privateKey: Domain.PrivateKey) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should remain private
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Signed-off-by: Francisco Javier Ribo Labrador <[email protected]>
Closing this PR as will be doing all the work for PresentationVerify in another PR |
Description:
We are integrating the SDJWT disclosure frames back from the pollux plugins migration.
Our tests are now able to create the presentation submission and validate the disclosed attributes accordingly.
I've left a comment in the code so that we remember the following:
Our library provider for SDJWT, uses requiredClaims attribute in the verify function to throw an error if the claim is not disclosed by the user.
In our case, we won't be passing any required claim, our process relies on:
To disclose any available field and then we will process and validate it through the validateInputDescriptor function in PresentationVerify task.
Checklist: