Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align the cfg compilation with the socket2 #160

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

linyihai
Copy link
Contributor

This shoud fixe hyperium/hyper#3817

@seanmonstar
Copy link
Member

I don't think it can be done with the cfg macro, since that still compiles to just an if expression, the code is still compiled and those methods don't exist. The cfg attribute is what is needed to prevent compiling methods calls that don't exist on that target.

@linyihai
Copy link
Contributor Author

Thank you. The cfg attribute has been used.

@dswij
Copy link
Member

dswij commented Dec 30, 2024

Have we checked that this fixes the issue?

@linyihai
Copy link
Contributor Author

Have we checked that this fixes the issue?

Hmm, I currently have no Haiku OS to test.

@vmlemon
Copy link

vmlemon commented Dec 31, 2024

Have we checked that this fixes the issue?

Hmm, I currently have no Haiku OS to test.

Kinda limited, in terms of integration testing that I can do, at the moment (only have remote access to a machine, via an Android VNC client, where I am, right now), but I was able to successfully compile this, in a Haiku VM, under QEMU, on MacOS:

Screenshot_20241231_172003_RVNC Viewer

Thanks, for working on this. :)

@seanmonstar seanmonstar merged commit 5f055e3 into hyperium:master Dec 31, 2024
16 checks passed
0x676e67 added a commit to 0x676e67/rquest that referenced this pull request Jan 1, 2025
@linyihai linyihai deleted the fix-with-functions branch January 1, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants