util: add a channel body #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2025
|
the msrv action failed here: https://github.com/hyperium/http-body/actions/runs/12635582609/job/35249835531 the relevant bit of our manifest getting in the way is the 4a5b234 removes this syntax, to be backwards compatible with older rust versions. |
this applies a review suggestion here: https://github.com/hyperium/http-body/pull/100/files#r1399781061 this commit refactors the channel-backed body in hyperium#100, changing the `mpsc::Receiver<E>` used to transmit an error into a `oneshot::Receiver<E>`. this should improve memory usage, and make the channel a smaller structure. in order to achieve this, some minor adjustments are made: * use pin projection, projecting pinnedness to the oneshot receiver, polling it via `core::future::Future::poll(..)` to yield a body frame. * add `Debug` bounds were needed. as an alternative, see tokio-rs/tokio#7059, which proposed a `poll_recv(..)` inherent method for a oneshot channel receiver.
this applies a review suggestion here: https://github.com/hyperium/http-body/pull/100/files#r1399780355 this commit refactors the channel-backed body in hyperium#100, changing the signature of `send_*` methods on the sender to require a mutable reference.
|
ah, i just saw that #128 was merged yesterday. i've rebased on top of that, so we can use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this branch represents a revival of #100, applying changes that were suggested in review. in particular, see 08aba95 and 4fed62f.
changes
use
sync::oneshotfor error channelthis commit refactors the channel-backed body in #100, changing the
mpsc::Receiver<E>used to transmit an error into aoneshot::Receiver<E>.this should improve memory usage, and make the channel a smaller
structure.
in order to achieve this, some minor adjustments are made:
use pin projection, projecting pinnedness to the oneshot receiver,
polling it via
core::future::Future::poll(..)to yield a body frame.add
Debugbounds were needed.use
&mut selfmethod receiversthis commit refactors the channel-backed body in #100, changing the
signature of
send_*methods on the sender to require a mutablereference.