-
Notifications
You must be signed in to change notification settings - Fork 52
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
We experimented with eager drain. In `(do (a) (b))` we don't care about the return value of `(a)` and with eager drain we can discard the return value without notifying through the graph. The problem is it introduces inconsistencies, e.g. in (when-let [x (e/watch !x)] (prn x) (do-something-with x)) the `(prn x)` form will run even when `x` turns falsy, because of its over-eagerness. This commit switches to a lazy drain implementation to fix the inconsistencies at the cost of additional graph churn.
- Loading branch information
Showing
2 changed files
with
27 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters