feat: UI for adding alerts for dashboard tiles #562

ernestii · 2025-01-20T18:37:30Z

changeset-bot · 2025-01-20T18:37:34Z

🦋 Changeset detected

Latest commit: 72c9926

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/api/src/controllers/dashboard.ts

wrn14897 · 2025-01-22T01:45:40Z

packages/api/src/controllers/dashboard.ts

+    await Alert.find({
+      dashboard: { $in: _dashboards.map(d => d._id) },
+      source: 'tile',
+    }),


double check we want to select all fields from the alert?

yep, I think all data is fine, we need full channel to populate the form

wrn14897 · 2025-01-22T01:50:25Z

packages/api/src/controllers/dashboard.ts

+      ...d,
+      tiles: d.tiles.map(t => ({
+        ...t,
+        config: { ...t.config, alert: alertsByTileId[t.id]?.[0] },


any reason we want to add alert field to config instead of adding it to the top level?

the reason what that it's easier to integrate alert form into Edit Chart form, since we can use same react-hook-form controller (it uses SavedChartConfig schema)

packages/api/src/controllers/dashboard.ts

wrn14897 · 2025-01-26T18:27:18Z

packages/common-utils/src/types.ts

@@ -346,6 +347,7 @@ export const SavedChartConfigSchema = z.intersection(
    z.object({
      name: z.string(),
      source: z.string(),
+      alert: AlertSchemaBase.optional(),


isn't this supposed to be AlertSchema ?

not really, since tile alerts are managed via /dashboard routes, we already know its source (Tile) and dashboardId and tileId, so we only need alert configuration here

Got it. But don't we still attach the redundant fields? from getDashboardAlerts, we fetch all fields in the alert. I guess the same thing applied to

hyperdx/packages/common-utils/src/types.ts

Line 269 in f1228de

alerts: z.array(AlertSchema).optional(),

packages/api/src/controllers/alerts.ts

packages/app/src/DBDashboardPage.tsx

packages/api/src/controllers/alerts.ts

packages/api/src/controllers/dashboard.ts

wrn14897 · 2025-01-27T18:36:32Z

packages/api/src/controllers/alerts.ts

+    Object.entries(alertsByTile).map(async ([tileId, alert]) => {
+      return await Alert.findOneAndUpdate(


nit: this async and await seem redundant

wrn14897 · 2025-01-27T22:00:02Z

The rest of the comments are minor. I'm going to clean this PR up and merge it

ernestii marked this pull request as draft January 20, 2025 18:37

ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch 5 times, most recently from a813a05 to 9aa649b Compare January 20, 2025 21:33

ernestii marked this pull request as ready for review January 20, 2025 21:34

ernestii requested review from MikeShi42 and wrn14897 January 20, 2025 21:34

ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch from 9aa649b to 67ee87d Compare January 21, 2025 04:10

ernestii force-pushed the ernest-/hdx-1329-saved-search-alert-ui-threshold-chart branch 2 times, most recently from 21dcf30 to a90737e Compare January 21, 2025 04:36

ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch 3 times, most recently from 6dda29e to 052e209 Compare January 21, 2025 05:34

ernestii force-pushed the ernest-/hdx-1329-saved-search-alert-ui-threshold-chart branch from a90737e to a41f979 Compare January 21, 2025 05:48

ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch from 052e209 to e7e9885 Compare January 21, 2025 05:48