-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(repo): promote contracts to root and update CI #1
Open
bitbeckers
wants to merge
23
commits into
main
Choose a base branch
from
chore/cleanup_repo_structure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set submodules to 'true'
set foundry profile to ci, update checkout and setup sequence
To inspect failing build
Trying to find MerkleProofUpgradeable.sol which keep throwing errors in CI
Version 5 and up doesn't contain the missing MerkleProofUpgradeable.sol
well, yeah...
add this explicityly
logging submodules dir and status
update force update to checkout v4.9.6 of oz-contracts-upgradeable
Getting closer to original amin
fails on checking out tag
going once
treololoosdflm,asdpofmsdjv
fasdnfjknsd
adsdnbas c
oasbnfckjasbckljasd c
dfashjbjchas
dfaskjcnas
Anything specific in here that I should take a look at? |
No, just tagged you as FYI to get a sense of where the contracts live and how the CI (should be) set up Deprioritised this for now as this PR broke the CI and we have enough to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at cleaning up the repo to only support the contracts instead of the monorepo from days past.
contracts
dir content to root