Bugfix/381 pagination errors #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Great, works well for me. Thanks Redirecting to the last page if I enter a higher page number in the URL makes most sense to me. |
Adds validation to redirect to first page when current page exceeds total pages
- Add disabled prop to PaginationButton component - Modify pagination button rendering to always show first/previous/next/last buttons to prevent components jumping across pages - Disable navigation buttons when at page boundaries - Update button styling for active and disabled states
Jipperism
force-pushed
the
bugfix/381-pagination-errors
branch
from
07e7e3d to
3407647
Compare
|
@holkexyz ok, redirects to last page now |
bitbeckers
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@holkexyz This PR should resolve the issues with pagination, please have a look.
It also fixes the styling so you know which page you are currently on, and always renders both first and last buttons at the bottom next to pagination to prevent the page numbers from jumping around between pages.
It also redirects you back to the first page when you go beyond the last one. We could just as easily set this to redirect you to the last page, it's up to you.