Fix/count after filter #440
Merged
+443
−491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Are you sure you want all these (merge-) commits in dev? Also, there's a conflict for |
- filter out two hypercerts in the frontend that have been burned - deleting a blank space from another hypercert id that was added to the filtered out list before
adding one hypercert ID to the list of filtered out hypercerts
Updates dependencies in response to dependabot alerts
Fixes the failing build by replacing `0x{string}` with the viem Address
type
The reason that we didn't see any FVM hypercerts were because there were exactly as many certs as filtered IDs. The getAllHypercerts method filtered out burned IDs and always substracted the length of the array from the count returned by the API. Which, led to 0, which led to 'no hypercerts found'
bitbeckers
force-pushed
the
fix/count_after_filter
branch
from
441ea42 to
03fb6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #432