WIP metadata image optimisation #260
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Push to PRD
fix: improve error handling in hypercert orders resolver
Push to PRD
Refactors the SupabaseCachingService to get all hypercert columns except for the image. Renamed the getMetadata method to getMetadataWithoutImage to make this explicit. Introduces MetadataImageService for fetching the image when the field is selected in a metadata query.
When the MetadataImageService gets a request, try and fetch the image form an in memory cache. If not present, fetch from Supabase and compress the image using sharp. Opted for compressions with webp as that should be nice for web images. Proof of concept
bitbeckers
changed the title
Coverage Report
File CoverageNo changed files found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on #257
When the MetadataImageService gets a request, try and fetch the image
form an in memory cache. If not present, fetch from Supabase and
compress the image using sharp.
Opted for compressions with webp as that should be nice for web images.
Proof of concept