Fix user controller to use custom Safe API Kit instance when interacting with Filecoin networks #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Filecoin documentation doesn't exactly specifiy the full path to be used with the SafeAPIKit SDK. After some digging I found that the API isn't expected to be under /api by default. That means it needs to be specified explicitly. https://docs.safe.global/sdk/api-kit/guides/migrate-to-v2
Without this patch the Multisig upsert strategy is trying to construct the SafeAPIKit instance using the default constructor. The problem is that on Filecoin and Filecoin Calibration the transaction service is hosted by a third party and thus needs a custom txServiceUrl in the config.
bitbeckers
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the Multisig upsert strategy is trying to construct the SafeAPIKit instance using the default constructor. The problem is that on Filecoin and Filecoin Calibration the transaction service is hosted by a third party and thus needs a custom txServiceUrl in the config.