Push to PRD #239
Merged
Push to PRD #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bitbeckers
commented
Feb 3, 2025
bitbeckers
commented
- Filecoin chain and RPC support
- SafeSignatureVerifier strategies
- Fix in awaiting order deletion
Updates the supported chains to support filecoin and filecoin calibration. Because of the JWT authentication of Glif the rpcFactory and evmClient builder were imported from the hypercerts-indexer. Test were created and updated accordingly
For some reason the Safe provider didn't play nicely with the EIP1193 client and threw the following errors: An unknown RPC error occurred.Details: request already sent (operation="fetchRequest.send", code=UNSUPPORTED_OPERATION, version=6.12.2)Version: [email protected] This patch just goes back to the easy init method of providing an RPC URL, to fix the issue.
For signature validations we need to make contract read calls. Safe protocol kit expects an RPC URL to make these calls, but on Filecoin mainnet and Filecoin Calibration they need to be JWT authenticated. This poses a problem with the initializer of the Safe SDK so we decided to use public RPCs on these two networks.
This is so that additional safe logic can be grouped into the safe folder while keeping the signature verification logic in its own folder.
The type signature that's generated in types/supabaseData.ts claims that chain_id is a number, while in reality it's a string.
Without this patch we solely rely on the Safe API Kit to figure out the URL to the Safe Transaction Service. However, this doesn't work for Filecoin Mainnet and Filecoin Calibration. These networks need an explicit URL.
Removes the 1193 provider previously introduces as this is no longer needed. Instead of providing the 1193 provider, we provide public RPCs to the filecoin provider
As we want to progress with this PR, the test pipeline should be green. However, we know the code isn't completely functional since the Safe intergration on filecoin is still broken. So, enforcing full coverage of the changes or continuity in the coverage doesn't make sense at this moment. All thresholds were reduces 1 percentage point. We'll manage.
Fixes a regression introduced in 12f4e1f, which meant orders weren't fetched/awaited correctly when deleting an order, resulting in 404's.
fix: order-deletion
To support filecoin we need to bypass the SafeSDK to verify Safe signatures. The SafeSignatureVerifier class was updated to support different strategies based on chain ID. A SignatureVerifierFactory was implemented to either execute a contract call or use the Safe SDK depending on the provided chain ID.
…trategies Implement contract signature verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.