Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up test suites and testing CI #203

Merged
merged 13 commits into from
Jan 2, 2025
Merged

Set up test suites and testing CI #203

merged 13 commits into from
Jan 2, 2025

Conversation

bitbeckers
Copy link
Collaborator

  • Updates allowlist and metadata controller test suites to use updated controller logic
  • Updates allowlist and metadata controllers to have better error handling and cleaner types
  • Updates other pieces of code affected by the type changes
  • Adds coverage reporter
  • Adds CI action for testing and test coverage reporting

Push Orders filter updates to PRD
Fixes the test file and controller to have passing tests and better
error handling for the metadata upload functionality of the
MetadataController
Restores the metadata validation endpoint testing. Additionally the full
metadata controller is using try catches and we updated the response
types. The response types have been made more simple and flexible, for
one to support the cases of validation where the processing can be
successful but the data is invalid. Lastly, responses where data is set
as null were cleaned so simply not return data.
Update all controllers to use the updated types structure. Rebuild the
updated API routes and Swagger.
Fixes the allowlist upload unit test flows. The current test suite was
breaking on missing imports and the tested flow and types were updated
to the latest implementation
wraps business logic in try-catches and updates response types where
needed
@bitbeckers bitbeckers added the enhancement New feature or request label Jan 2, 2025
@bitbeckers bitbeckers requested a review from pheuberger January 2, 2025 21:12
@bitbeckers bitbeckers self-assigned this Jan 2, 2025
Adds vitest coverage reporting and CI action
Fixes the test file and controller to have passing tests and better
error handling for the metadata upload functionality of the
MetadataController
Restores the metadata validation endpoint testing. Additionally the full
metadata controller is using try catches and we updated the response
types. The response types have been made more simple and flexible, for
one to support the cases of validation where the processing can be
successful but the data is invalid. Lastly, responses where data is set
as null were cleaned so simply not return data.
Update all controllers to use the updated types structure. Rebuild the
updated API routes and Swagger.
Adds vitest coverage reporting and CI action
Copy link

github-actions bot commented Jan 2, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 16.3% (🎯 15%) 813 / 4986
🟢 Statements 16.3% (🎯 15%) 813 / 4986
🟢 Functions 54.32% (🎯 49%) 44 / 81
🟢 Branches 57.89% (🎯 54%) 132 / 228
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/controllers/AllowListController.ts 90% 90% 100% 90% 107-114
src/controllers/BlueprintController.ts 0% 0% 0% 0% 1-391
src/controllers/HyperboardController.ts 0% 0% 0% 0% 1-966
src/controllers/MarketplaceController.ts 0% 0% 0% 0% 1-492
src/controllers/MetadataController.ts 41.37% 72.72% 50% 41.37% 61-73, 116-180, 214-228, 237-244, 261-308
src/controllers/UserController.ts 0% 0% 0% 0% 1-102
Generated in workflow #7 for commit 5797793 by the Vitest Coverage Report Action

updates gha test script to use env var
@bitbeckers bitbeckers merged commit d9c0a6b into develop Jan 2, 2025
1 check passed
@bitbeckers bitbeckers deleted the feat/init_testing_ci branch January 21, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant