-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up test suites and testing CI #203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bitbeckers
commented
Jan 2, 2025
- Updates allowlist and metadata controller test suites to use updated controller logic
- Updates allowlist and metadata controllers to have better error handling and cleaner types
- Updates other pieces of code affected by the type changes
- Adds coverage reporter
- Adds CI action for testing and test coverage reporting
Push Orders filter updates to PRD
Fixes the test file and controller to have passing tests and better error handling for the metadata upload functionality of the MetadataController
Restores the metadata validation endpoint testing. Additionally the full metadata controller is using try catches and we updated the response types. The response types have been made more simple and flexible, for one to support the cases of validation where the processing can be successful but the data is invalid. Lastly, responses where data is set as null were cleaned so simply not return data.
Update all controllers to use the updated types structure. Rebuild the updated API routes and Swagger.
Fixes the allowlist upload unit test flows. The current test suite was breaking on missing imports and the tested flow and types were updated to the latest implementation
wraps business logic in try-catches and updates response types where needed
Adds vitest coverage reporting and CI action
Fixes the test file and controller to have passing tests and better error handling for the metadata upload functionality of the MetadataController
Restores the metadata validation endpoint testing. Additionally the full metadata controller is using try catches and we updated the response types. The response types have been made more simple and flexible, for one to support the cases of validation where the processing can be successful but the data is invalid. Lastly, responses where data is set as null were cleaned so simply not return data.
Update all controllers to use the updated types structure. Rebuild the updated API routes and Swagger.
Adds vitest coverage reporting and CI action
…rcerts-api into feat/init_testing_ci
Coverage Report
File Coverage
|
updates gha test script to use env var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.