Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statuses to Submission elements to indicate whether it is spam #185

Open
wants to merge 3 commits into
base: develop-v4
Choose a base branch
from

Conversation

nstCactus
Copy link

@nstCactus nstCactus commented Jan 11, 2024

This PR fixes #58.

It:

  • adds an isSpam column in the contactform_submissions table
  • adds statuses to the Submission element type
  • implements the unified element editor

This gives the ability to use the status dropdown in the element index to show only Not spam / Spam submissions or all of them.

image

The unified element editor :

  • adds a metadata sidebar with the element ID, status & creation/update dates
  • adds the ability to open the submission in the editor slideout from the element index
  • voids the need for a controller
image image

This PR needs #186, otherwise submissions marked as spam by the contact-form-honeypot plugin will be saved as Not spam.

@rosskenney rosskenney self-requested a review January 12, 2024 19:48
@rosskenney rosskenney self-assigned this Jan 12, 2024
@nstCactus
Copy link
Author

Hi @rosskenney,

Did you get a chance to review this PR? I'm available to make adjustments if needed!

@DynamiteGoesBoom
Copy link
Contributor

@nstCactus thanks for this and other PRs 🎉 We'll try and review these all soon and appreciate the help with these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants