fix issues reported by PHPStan

hwi · Jan 1, 2025 · a0ffe6b · a0ffe6b
1 parent f77a9bc
commit a0ffe6b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -19,3 +19,4 @@ parameters:
         - '#Parameter \$event of method HWI\\Bundle\\OAuthBundle\\Controller\\Connect\\AbstractController::dispatch\(\) has invalid type Symfony\\Component\\EventDispatcher\\Event.#'
         - '#Parameter \#2 \$array of function implode expects array<string>, array<int, array\|string\|null> given.#'
         - '#PHPDoc type DOMNode of property HWI\\Bundle\\OAuthBundle\\OAuth\\Response\\SensioConnectUserResponse::\$data is not covariant with PHPDoc type array of overridden property HWI\\Bundle\\OAuthBundle\\OAuth\\Response\\AbstractUserResponse::\$data#'
+        - '#Call to function method_exists\(\) with Symfony\\Component\\Security\\Http\\Authenticator\\Debug\\TraceableAuthenticator#'
diff --git a/src/DependencyInjection/CompilerPass/ResourceOwnerCompilerPass.php b/src/DependencyInjection/CompilerPass/ResourceOwnerCompilerPass.php
@@ -67,11 +67,11 @@ private function registerResourceOwnerTypeClassParameters(ContainerBuilder $cont
             $resourceOwnerClass = $definition->getClass();
 
             // Check whether a ResourceOwner class exists only if resource owner was set by its "options.type"
-            if (false === preg_match('~^%(?P<parameter>hwi_oauth.resource_owner.(?P<type>.+).class)%$~', $resourceOwnerClass, $match)) {
+            if (false === $result = preg_match('~^%(?P<parameter>hwi_oauth.resource_owner.(?P<type>.+).class)%$~', $resourceOwnerClass, $match)) {
                 return;
             }
 
-            if (!($match['type'] ?? null)) {
+            if (0 === $result || !$match['type']) {
                 continue;
             }
 

diff --git a/src/Security/Http/Firewall/RefreshAccessTokenListener.php b/src/Security/Http/Firewall/RefreshAccessTokenListener.php
@@ -40,7 +40,7 @@ protected function refreshToken(OAuthToken $token): OAuthToken
             return $this->authenticator->refreshToken($token);
         }
 
-        if ($this->authenticator instanceof TraceableAuthenticator) {
+        if ($this->authenticator instanceof TraceableAuthenticator && method_exists($this->authenticator, 'getAuthenticator')) {
             $authenticator = $this->authenticator->getAuthenticator();
 
             if ($authenticator instanceof OAuthAuthenticator) {