fix issues reported by PHPStan

hwi · Jan 1, 2025 · 353e87c · 353e87c
1 parent f77a9bc
commit 353e87c
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -2,10 +2,6 @@ name: CI
 
 on:
   push:
-    branches:
-      - master
-    paths-ignore:
-      - '**.md'
   pull_request:
     paths:
       - '.github/workflows/**'

diff --git a/phpstan.neon b/phpstan.neon
@@ -19,3 +19,4 @@ parameters:
         - '#Parameter \$event of method HWI\\Bundle\\OAuthBundle\\Controller\\Connect\\AbstractController::dispatch\(\) has invalid type Symfony\\Component\\EventDispatcher\\Event.#'
         - '#Parameter \#2 \$array of function implode expects array<string>, array<int, array\|string\|null> given.#'
         - '#PHPDoc type DOMNode of property HWI\\Bundle\\OAuthBundle\\OAuth\\Response\\SensioConnectUserResponse::\$data is not covariant with PHPDoc type array of overridden property HWI\\Bundle\\OAuthBundle\\OAuth\\Response\\AbstractUserResponse::\$data#'
+        - '#Call to function method_exists\(\) with Symfony\\Component\\Security\\Http\\Authenticator\\Debug\\TraceableAuthenticator#'
diff --git a/src/DependencyInjection/CompilerPass/ResourceOwnerCompilerPass.php b/src/DependencyInjection/CompilerPass/ResourceOwnerCompilerPass.php
@@ -71,7 +71,7 @@ private function registerResourceOwnerTypeClassParameters(ContainerBuilder $cont
                 return;
             }
 
-            if (!($match['type'] ?? null)) {
+            if (!$match['type']) {
                 continue;
             }
 

diff --git a/src/Security/Http/Firewall/RefreshAccessTokenListener.php b/src/Security/Http/Firewall/RefreshAccessTokenListener.php
@@ -40,7 +40,7 @@ protected function refreshToken(OAuthToken $token): OAuthToken
             return $this->authenticator->refreshToken($token);
         }
 
-        if ($this->authenticator instanceof TraceableAuthenticator) {
+        if ($this->authenticator instanceof TraceableAuthenticator && method_exists($this->authenticator, 'getAuthenticator')) {
             $authenticator = $this->authenticator->getAuthenticator();
 
             if ($authenticator instanceof OAuthAuthenticator) {
-Original file line number
+Diff line change
@@ Expand Up @@
                     return;
                 }
-                if (!($match['type'] ?? null)) {
+                if (!$match['type']) {
                     continue;
                 }
@@ Expand Down @@