Add robot specific velocity presets #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafal-gorecki
requested changes
Dec 17, 2024
There was a problem hiding this comment.
I miss the functionality of choosing a robot in the launch file. An example of how a file is killed based on the robot name: https://github.com/husarion/panther_ros/blob/ros2-devel/husarion_ugv_controller/launch/controller.launch.py#L176
I would also move the configs to the config folder inside the package.
Co-authored-by: Rafal Gorecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Velocity presets between joy2twist and this package were inconsistent on Lynx and Panther robots resulting in wrong turn radius between speed modes. Current values come from joy2twist presets, only Lynx slow mode was speed up to provide better control as TX16S remote has more precise gimbals with higher travel distance.
Changes
config/crsf_teleop_{lynx,panther}.yamlparameter files were added andcompose.yamlwas changed