Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache storage content into file system instead of database #89

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

isaacfi
Copy link

@isaacfi isaacfi commented Apr 16, 2021

With this change the issues 61 and 56 will be solved

@isaacfi
Copy link
Author

isaacfi commented May 21, 2021

Hi @hurshi, @erickok and @franticn,

Have you reviewed this pull request? I think that is an important upgrade to allow the big files storage.

BR.

@erickok
Copy link
Contributor

erickok commented May 22, 2021

Hi @isaacfi . I am not a maintainer of this package, but I wuickly took a look at your PR. One thing a noticed is that you still use the database to store metadata. Do you think (and this is just an open question) we can do away with the database entirely?

In principle I think it's great to store data on disk directly instead of the database, but this is a quite different approach to the existing implementation so it warrants some careful consideration and ideally even a benchmark.

@isaacfi
Copy link
Author

isaacfi commented Aug 9, 2021

Hi @erickok, I think that the metadata stored in the database, speed up the search of referenced files. And yes, I know that this is a breakchange, but the problem with the original implementation, is that the use of database as storage limit the size of the files and in my case this is a huge problem, because I am storing videos and large images.

I hope that @hurshi considers this change soon.

BR.

@erickok
Copy link
Contributor

erickok commented Aug 9, 2021

I'm not the library creator or maintainer but yes I agree Id also personally like a file based system a bit better. But it works (for us) so I'm not complaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants