Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guntoro Yudhy Kusuma #12

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

guntoroyk
Copy link

No description provided.

@guntoroyk
Copy link
Author

Selamat pagi mas Wika.
Aplikasi Fancy Todo yg kubuat ini memiliki fitur:

  • minimum requirement tugas
  • signup/login dengan google sigin (default password ada di .env)
  • bisa menambahkan todo ke google calendar
    Caranya klik salah satu todo lalu akan muncul Todo Detail, di situ ada tombol Add to Google Calendar. Syaratnya harus login pake google sign in, jika tidak harus klik tombol Authorize dulu.

Ini isi dari .env nya
PORT=3000
SECRET_JWT='secretooo'
GOOGLE_CLIENT_ID=1075139297559-k7it3o7qfuvahtvn1n8vd0vbpabvpufg.apps.googleusercontent.com
GOOGLE_RANDOM_PWD='hahahihi'

@guntoroyk
Copy link
Author

Oh ya untuk kendala saat mengerjakan tugas:

  • lama banget ngerjain front end. Belum tau pattern yg tepat untuk menggunakan jQuery nya, jadi code kurang rapi.
  • belum terbiasa di css jadi desain masih sederhana hehe

@guntoroyk
Copy link
Author

untuk menjalankan server

npm run dev

untuk menjalankan client (port harus 8080)

live-server --host=localhost --port=8080

@guntoroyk
Copy link
Author

jangan lupa mongodb nya dinyalain dulu ya mas.. kalau nggak nanti tidak bisa login

@guntoroyk
Copy link
Author

yg belum saya handle:

  • setelah logout kemudian login pake akun lain harus reload dulu untuk dapetin todonya

@guntoroyk
Copy link
Author

Ketika login bukan pakai google sign in, kemudian ingin menambahkan todo ke google calendar maka harus klik Authorize dulu. Tapi jika tombol Authorize tidak muncul coba klik salah satu todo yang lain atau reload tab terlebihh dahulu.

@@ -0,0 +1 @@
node_modules
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.env jangan lupa di ignore

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

siap mas

@@ -0,0 +1 @@
{"access_token":"ya29.Il99BzwCUaDasHDWCAwfzLGnOoueN61AK01iK85jfI4l5DihxN-tNmDFOAiateG2sxuzKdjIOQwYiaB8x5V7xrCgxgON60WVYlHjM_n-QMyoo6l5u6XzPu_mpO6df4OojQ","refresh_token":"1/o80NzXRfevGpC6qmz9NF3psxBKcMxKgwuRLC0Gym5hs","scope":"https://www.googleapis.com/auth/calendar","token_type":"Bearer","expiry_date":1567960858614}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ini apa ya?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itu dari calendar api deh kayake mas. setiap ngakses calendar api kaya butuh access token gitu. makanya disimpan di token.json

# fancy-todo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jika ini untuk API Documentation Server, sebaiknya di folder server saja

server/app.js Outdated
const app = express();
const PORT = process.env.PORT || 3000;

mongoose.connect('mongodb://localhost/fancy-todo', {useNewUrlParser: true})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untuk uri ini sebaiknya dibuat dalam variable, sehingga mempermudah proses production kedepannya

@WikaSilo
Copy link
Collaborator

WikaSilo commented Sep 12, 2019

  1. credential data: .env, credential.json, token,json sebaiknya di ignore, next kirim via slack saja ya
  2. beberapa method harus reload dulu
  3. untuk dapetin todo lagi setelah logout, fetch ulang lagi

Jika ada perbaikan dan deploy, slack ke instructor yaa

@guntoroyk
Copy link
Author

  1. credential data: .env, credential.json, token,json sebaiknya di ignore, next kirim via slack saja ya

siap mas.. thanks saran-sarannya..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants