Improve SSL certificate handling #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files are generated several directories above the proxy.yml file. I'm not wild about this kind of relative path, but all of this happens in `vendor` which users shouldn't be messing around in. If you've deleted the `vendor` dir then you probably don't want these anyway.
smccafferty
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to allow
local-vipto automatically generate certificates likelocal-server. Specifically, it brings in the changes in these PRs:...and makes a few other tweaks to address the slightly more limited local VIP use case. Most notably, it makes some more restrictive assumptions about domains and TLDs, defaulting to using the domain/TLD without a subdomain as the primary site, and not allowing for multiple domains in the way
local-serverdoes—in other words it's only really meant to run one VIP domain at a time, and you'd need to destroy and rebuild the proxy to run a different one.This will resolve #16.