-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ssl command to download mkcert and generate ssl certificates #465
Merged
+411
−208
Merged
Changes from 44 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
480f504
Add ssl command to download mkcert and generate ssl certificates
shadyvb 3b1dd4f
Add link to install mkcert after errors installing it
shadyvb 824746e
Remove redundant return statement
shadyvb 901b3b9
Improve logging around errors with ssl
shadyvb afad00a
Remove redundant output
shadyvb f2786f9
Removed duplicate handling of get_mkcert_binary()
shadyvb 9441243
Fix docblock
shadyvb 26494bd
:nail_care: Fix CS
shadyvb b0bb233
Programmatically create SSL certificate and use with Traefik
shadyvb 1be8adf
Allow custom domain name/tld from #341
shadyvb 60baaf5
Fix function args
shadyvb aa942fc
Fix an error with the run command
shadyvb 5c025de
Skip verifying https for S3 requests
shadyvb 97e4ce9
Try to fix s3 bucket/path mapping
shadyvb cfec957
Better detect WSL environment
shadyvb 9827897
Restart the proxy container after generating a certificate
shadyvb 7f36778
Add support for extra custom domains
shadyvb af3b6c0
Stop starting if domain has changed to avoid orphan containers
shadyvb 859114c
Only attempt to restart the proxy container if it is running
shadyvb e28a24a
Check if secure is set to false to avoid generating SSL certificate
shadyvb e259410
Revert "Check if secure is set to false to avoid generating SSL certi…
shadyvb e20718a
:nail_care: CS polish
shadyvb 578c219
Install mkcert for tests
shadyvb 4091cad
Add note on mkcert installation url and location
shadyvb b50194c
More verbose output on detected os arch
shadyvb 6b9708f
Fix arch detection for linux
shadyvb ef984c4
Fix missing name/tld config
shadyvb a3d42f8
Fix missing domains config key
shadyvb ce9fb0c
Merge remote-tracking branch 'origin/master' into product-dev-987/ssl…
shadyvb 2a73d9f
Test connectivity to site in CI
shadyvb 81ab150
Add aux service URLs to generated certificate
shadyvb 90ce957
Fix S3 and Tachyon issues with bucket path
shadyvb 4e6fd76
Add a warning for missing hosts entries
shadyvb 7c0a020
Fix indentation
shadyvb 8a79a58
Remove relative path use in traefik config
shadyvb 2634b85
Fix generation of hosts entries note
shadyvb 0d6430e
Fix generation of cert around default domain
shadyvb 6c187a1
Less testing output
shadyvb bd8eabc
Do not generate SSL for altis.dev
shadyvb 37518b7
More efficient domain selection
shadyvb b164550
Correct typo
shadyvb 72c6318
Add traefik.domain label for future multi-instance SSL generation
shadyvb b008194
Return instead of exit
shadyvb 4e26c8f
Document custom domains and SSL command features
shadyvb 2f11c98
Move SSL generation out of experimental section
shadyvb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this under experimental features? Custom domains / codespaces perhaps but I think the SSL stuff itself doesn't need to be considered experimental as we need it to work for the default TLD at the very least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's experimental in the sense that it is tied to custom domains which is experimental 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, and we might want to remove it altogether in favor of Traefik managing it on its own, given the centralization needed. I'm writing the issue around that that would explain my suggested approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #475
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it’s fine to not list it as experimental personally, codespaces definitely will be to start with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roborourke Updated docs in 2f11c98 , should be ready for a final review.