Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ssl command to download mkcert and generate ssl certificates #465
Add ssl command to download mkcert and generate ssl certificates #465
Changes from 8 commits
480f504
3b1dd4f
824746e
901b3b9
afad00a
f2786f9
9441243
26494bd
b0bb233
1be8adf
60baaf5
aa942fc
5c025de
97e4ce9
cfec957
9827897
7f36778
af3b6c0
859114c
e28a24a
e259410
e20718a
578c219
4091cad
b50194c
6b9708f
ef984c4
a3d42f8
ce9fb0c
2a73d9f
81ab150
90ce957
4e6fd76
7c0a020
8a79a58
2634b85
0d6430e
6c187a1
bd8eabc
37518b7
b164550
72c6318
b008194
4e26c8f
2f11c98
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to check what the situation with this and WSL is. If you can run .exe from WSL, or global commands from there we might be ok. @missjwo might be able to assist in testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, testing cross-platform was supposed to be the next step. I can do that in a VM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WSL won’t replicate accurately within a VM so far as I know, since it’s a VM itself.
For WSL though, the arch will be Linux because it’s literally a Linux VM you’re running inside of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If composer is running within WSL, the certificate would be automatically installed to Windows store itself, which is a problem. We'll need to add docs on manually accepting the root CA.
Also, does this mean we do not support Windows itself but rather WSL ? ( I have not used WSL nor Docker on Windows )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there was a PR to support windows natively but I think there were some limitations to that. We do have a way to check it’s a WSL environment at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can run .exe files from WSL https://docs.microsoft.com/en-us/windows/wsl/filesystems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to test stuff - just let me know when the PR is ready to be tested and what i should be looking out for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shadyvb Correct, only WSL is supported, per https://docs.altis-dxp.com/local-server/windows/
You can execute exe files, yeah; WSL will transparently map execution of those, and execute them. Note though,
php_uname( 's' )
will return Linux because it is Linux. We need to use theCommand::is_wsl()
function to detect WSL, not uname.Also happy to test with my WSL env, and screenshare as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to test on my windows machine. Let me know when the PR is ready to be tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default behaviour here should be the following:
<project>.<tld>
and*.<project>.<tld>
(no harm in them being there by default, even if someone calls the function with other domains, its better to avoid surprises here IMO than assume someone knows it might be a deleterious action if we don't explicitly call that out)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traefik will need to know about the extra domains too 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the extra domains support to nginx ⬆️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added the configured domain(s) to the domains within
generate()
command as discussed, alsoaltis.dev *.altis.dev
.