Enable XRay by default #255
Conversation
This was causing problem with the Cloud module's default setting fro XRay so we should avoid errors with a vanilla install. Devs will need to switch off both the cloud module setting and the local server setting to fully turn off xray locally. Fixes #254
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
There was a problem hiding this comment.
This change is fine. However, before closing out #254 -- and given that it's indicated in the notes -- I would request that there be documentation added as part of #254 that explains how to disable Xray locally (and possibly why). Since the fixed keyword is used in the PR, merging this will auto-close that issue and I feel like there should be a separate, documentation component to this, hence requesting changes.
|
@jazzsequence we haven't documented any of the new config options for local server and the containers you can turn off yet because the feature isn't really complete. The other modules that would be affected by turning off say the ES container don't do any checks against the Local Server config so I'm not sure we're quite there yet. Are you asking for a new issue to be created for the docs or for all the docs to be added to this PR? I'd rather do them all together when we're ready to. I'll create a new issue for that so that this change doesn't need to be held up. |
|
Created #257 as a follow up to document the options. |
There was a problem hiding this comment.
Are you asking for a new issue to be created for the docs or for all the docs to be added to this PR?
I was specifically asking for documentation about turning Xray off, specifically, since it's mentioned in the PR description ("Devs will need to switch off both the cloud module setting and the local server setting to fully turn off xray locally.") -- if devs are expected to know a thing, the thing should be documented.
However, if the feature is as yet unannounced, and there's more associated documentation needed to cover all the aspects, and we have an issue for that, that's enough for me to have the ticket and toggle the default back to true.
This was causing problem with the Cloud module's default setting fro XRay so we should avoid errors with a vanilla install. Devs will need to switch off both the cloud module setting and the local server setting to fully turn off xray locally.
Fixes #254