Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb endpoint and access token #19

Merged
merged 5 commits into from
Sep 23, 2024
Merged

Plumb endpoint and access token #19

merged 5 commits into from
Sep 23, 2024

Conversation

bpronan
Copy link
Contributor

@bpronan bpronan commented Sep 23, 2024

Plumbing the endpoint and JWT access token from the python interface through to the request headers for the reconstruction and shard POST|PUT calls.

Partially resolves:
https://linear.app/xethub/issue/STO-35/secure-read-path
https://linear.app/xethub/issue/STO-36/secure-write-path

@bpronan bpronan requested review from sirahd and jgodlew September 23, 2024 16:43
Copy link
Contributor

@jgodlew jgodlew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some minor nits.

hf_xet/src/lib.rs Outdated Show resolved Hide resolved
data/src/configurations.rs Outdated Show resolved Hide resolved
data/src/cas_interface.rs Outdated Show resolved Hide resolved
@bpronan bpronan merged commit 6950115 into main Sep 23, 2024
1 check passed
@bpronan bpronan deleted the brian/plumb-jwt branch September 23, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants