Drop xet_error. #134
Merged
Drop xet_error. #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafvayner
approved these changes
Jan 7, 2025
README.md
Outdated
| @@ -21,7 +21,7 @@ Xet-core is the repo responsible for Rust-based code running on the client machi | |||
| * [parutils](src/parutils): Provides parallel execution utilities relying on Tokio (ex. parallel foreach). | |||
| * [progress_reporting](src/progress_reporting): offers ReportedWriter so progress for Writer operations can be displayed. | |||
| * [utils](src/utils): general utilities - **unclear how much is currently in use** | |||
| * [xet_error](src/xet_error): Error utility crate, widely used for anyhow! logging in other crates. | |||
| * [thiserror](src/thiserror): Error utility crate, widely used for anyhow! logging in other crates. | |||
There was a problem hiding this comment.
we should get rid of this line
seanses
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xet_error was a source drop of thiserror with integrated logging and the ability to put in a breakpoint to note exception propagation. However, the benefits of maintaining a source drop with changes, at least on client side, are less clear in the current ecosystem and with upgrades to the thiserror package (e.g. better integrated stacktracing).
This PR removes xet_error and reverts everything back to the original thiserror implementation.